Port global search menu to focus trapped NcHeaderMenu #36203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
enhancement
3. to review
|
/backport to stable25 |
2 tasks
|
I added back the pull request template you accidentally removed.
Can you add the screenshots, even if they are supposed to look the same? |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-search-menu
branch
from
6c4fce6
to
966872f
Compare
Done! Also removed the link to prevent having to reopen for the backport |
nickvergessen
approved these changes
Jan 18, 2023
skjnldsv
added
4. to release
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tabbing after hitting the last result will loop back focus to the search input
No visual changes 🔎
Checklist